Remove languageserver-types dependency in favor of -protocol

[colin-grant-work]

What it does

The vscode-languageserver-types package is part of and reexported by the vscode-languageserver-protocol package. There's no good reason to have both, and having both separately could introduce dependency management issues, so this replaces all references to vscode-languageserver-types with vscode-languageserver-protocol. This will substantially reduce the diff of #10265.

How to test

1. There should be no changes in application behavior - this was a pure search-and-replace operation.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[msujew]

Looks good. However, I found some references to vscode-languageserver-types you seemed to have overlooked:

• lsp-types.ts
• severity.ts

Also, there is still some reference to it in our core/package.json. I thought the idea was to not depend on a specific version of vscode-languageserver-types, so I'd remove it there as well.

[colin-grant-work]

Looks good. However, I found some references to vscode-languageserver-types you seemed to have overlooked:

• lsp-types.ts
• severity.ts

Also, there is still some reference to it in our core/package.json. I thought the idea was to not depend on a specific version of vscode-languageserver-types, so I'd remove it there as well.

Good catches - thanks. I was so concerned about the shared dependency that that's what I searched for, ignoring core.

[vince-fugnitto]

@colin-grant-work do you mind adding a breaking change entry for anyone using the vscode-languageserver-types import as it is no longer re-exported (shared) from core? Other than that the changes look good to me, and I confirmed there are no uses of vscode-languageserver-types directly anymore in the codebase.

[colin-grant-work]

@vince-fugnitto, I've added an entry to the changelog, but under 1.22 - no need to rush to get it in before the release on Thursday.

[vince-fugnitto]

The changes look good to me 👍