tasks: Use valid column when creating range for problem matcher#10509
Merged
tasks: Use valid column when creating range for problem matcher#10509
Conversation
colin-grant-work
approved these changes
Dec 6, 2021
Contributor
colin-grant-work
left a comment
There was a problem hiding this comment.
I confirm the presence of the bug on master and the efficacy of this fix. 👍
2716216 to
ef36105
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
When calling
Range.createwith a value larger than >2^32-1, the function will throw an error. We do this when building ranges parsed from matched problems where we don't receive start/end columns:theia/packages/task/src/node/task-abstract-line-matcher.ts
Line 204 in afd980a
Number.MAX_VALUEis something like 10^308. SinceRange.createalways throws in this case, we never receive any matched problems from the server, and any errors are swallowed by acatch { return undefined }.How to test
A file named
test.jsin the project root:A task definition like this:
{ "label": "Test Matcher", "type": "shell", "command": "node", "args": [ "test.js" ], "problemMatcher": { "name": "test-matcher", "owner": "test-matcher", "fileLocation": [ "relative", "${workspaceFolder}" ], "pattern": { "regexp": "^\\[[A-Z]+\\] (INFO|WARNING|ERROR) (.*):(\\d+) (.*)$", "severity": 1, "file": 2, "line": 3, "message": 4 } } }Test Matchertasktest.jsand assert that the first line is marked with a warningReview checklist
Reminder for reviewers