Fix running plugin host on electron windows#10518
Merged
msujew merged 1 commit intoeclipse-theia:masterfrom Dec 14, 2021
Merged
Fix running plugin host on electron windows#10518msujew merged 1 commit intoeclipse-theia:masterfrom
msujew merged 1 commit intoeclipse-theia:masterfrom
Conversation
msujew
approved these changes
Dec 8, 2021
Member
msujew
left a comment
There was a problem hiding this comment.
The changes look good to me. I can confirm that the issue exists on master and is addressed by the changes nicely 👍
Member
|
@Tom-Yucw Please don't create a new PR for every change, and simply add your changes to this PR. If you choose to amend to your first commit, you can force push them using |
Member
|
@msujew should we merge for this week's release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Closes #6846
to run plugins created by yo @theia/plugin on windows.
How to test
A new instance is showed up successfully on windows.
Review checklist
Reminder for reviewers