Add command for opening the containing folder of a file#10523
Merged
msujew merged 1 commit intoeclipse-theia:masterfrom Jan 12, 2022
Merged
Add command for opening the containing folder of a file#10523msujew merged 1 commit intoeclipse-theia:masterfrom
msujew merged 1 commit intoeclipse-theia:masterfrom
Conversation
AlexandraBuzila
force-pushed
the
open-containing-folder
branch
from
8dea8fc to
83be22a
Compare
packages/navigator/src/electron-browser/electron-navigator-menu-contribution.ts
Outdated
Show resolved
Hide resolved
packages/navigator/src/electron-browser/electron-navigator-menu-contribution.ts
Outdated
Show resolved
Hide resolved
packages/navigator/src/electron-browser/electron-navigator-menu-contribution.ts
Outdated
Show resolved
Hide resolved
AlexandraBuzila
force-pushed
the
open-containing-folder
branch
from
83be22a to
3f98b5a
Compare
Contributor
Author
|
Thank you for the review, @vince-fugnitto! I integrated your feedback in the updated commit. |
packages/navigator/src/electron-browser/electron-navigator-menu-contribution.ts
Outdated
Show resolved
Hide resolved
AlexandraBuzila
force-pushed
the
open-containing-folder
branch
from
3f98b5a to
ce4e968
Compare
msujew
reviewed
Jan 4, 2022
packages/navigator/src/electron-browser/electron-navigator-menu-contribution.ts
Show resolved
Hide resolved
packages/navigator/src/electron-browser/electron-navigator-menu-contribution.ts
Outdated
Show resolved
Hide resolved
packages/navigator/src/electron-browser/electron-navigator-menu-contribution.ts
Outdated
Show resolved
Hide resolved
AlexandraBuzila
force-pushed
the
open-containing-folder
branch
from
ce4e968 to
727da82
Compare
Contributor
Author
|
Thank you for the review! I updated the commit and rebased it on master. |
AlexandraBuzila
force-pushed
the
open-containing-folder
branch
from
727da82 to
422a778
Compare
msujew
reviewed
Jan 10, 2022
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
The code looks good, although there is an issue with Windows and this feature not working there. Luckily, it can be easily fixed :)
Afterwards, I think this PR is good to go.
packages/navigator/src/electron-browser/electron-navigator-menu-contribution.ts
Outdated
Show resolved
Hide resolved
packages/navigator/src/electron-browser/electron-navigator-menu-contribution.ts
Outdated
Show resolved
Hide resolved
AlexandraBuzila
force-pushed
the
open-containing-folder
branch
from
422a778 to
26a5017
Compare
msujew
reviewed
Jan 10, 2022
packages/navigator/src/electron-browser/electron-navigator-menu-contribution.ts
Outdated
Show resolved
Hide resolved
A new 'OPEN_CONTAINING_FOLDER' command was added for the electron application. It opens the native file explorer at the path where the selected resource (or resources) from the file navigator is located. Signed-off-by: Alexandra Buzila <abuzila@eclipsesource.com>
AlexandraBuzila
force-pushed
the
open-containing-folder
branch
from
26a5017 to
52447dc
Compare
msujew
approved these changes
Jan 11, 2022
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
I can confirm that the feature works as expected on Windows and Ubuntu (VM) 👍
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
A new 'OPEN_CONTAINING_FOLDER' command was added for the electron application.
It opens the native file explorer at the path where the selected resource (or resources) from the file navigator is located.
Fixes #10522
How to test
Select a file or directory in the file explorer, open the context menu and select the
Open Containing Folderaction. The OS file explorer should open at the path where the file is located.Review checklist
Reminder for reviewers
Signed-off-by: Alexandra Buzila abuzila@eclipsesource.com