ovsx-client: add additional isVersionLTE unit tests to cover preview versions#10530
Merged
vince-fugnitto merged 1 commit intomasterfrom Dec 13, 2021
Merged
ovsx-client: add additional isVersionLTE unit tests to cover preview versions#10530vince-fugnitto merged 1 commit intomasterfrom
isVersionLTE unit tests to cover preview versions#10530vince-fugnitto merged 1 commit intomasterfrom
Conversation
The commit adds additional tests for `isVersionLTE` which is used by the
`ovsx-client` to compare versions of an extension. The commit adds
unit-tests to cover `preview` versions of an extension (`*-next.{sha}`).
Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added
test
colin-grant-work
approved these changes
Dec 13, 2021
Contributor
colin-grant-work
left a comment
colin-grant-work
left a comment
There was a problem hiding this comment.
Tests are passing, and these checks look comprehensive to me.
marcdumais-work
approved these changes
Dec 13, 2021
Contributor
marcdumais-work
left a comment
marcdumais-work
left a comment
There was a problem hiding this comment.
LGTM, Thanks Vince
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request adds additional unit-tests to verify that
isVersionLTEsuccessfully handlespreviewversions of an extension (form of*-next.{sha}).How to test
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com