Improve plugin-view toolbar lifecycle#10546
Merged
colin-grant-work merged 2 commits intomasterfrom Jan 6, 2022
Merged
Conversation
810089e to
77282e5
Compare
msujew
approved these changes
Jan 3, 2022
Member
msujew
left a comment
There was a problem hiding this comment.
I can confirm that the issue exists on master and is addressed by this change.
- The file tree/list icon correctly changes using the maven extension
- Other buttons remain working as expected (no regressions)
The code looks good to me 👍
77282e5 to
2a399d1
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #9075.
Closes #9080.
This PR builds on #9080. That PR addressed a bug in the fetching of values from workspace scope in the
MonacoConfigurationService, but did not fix the problem with missing events for updating toolbars in plugin-contributed views. This PR makes several changes to address the latter problem:.withutility from theViewContextKeyService. That utility was designed to check whether awhenexpression's conditions would be satisfied given certain assumptions, but it caused two or four change events to be fired by theContextKeyServicefor every check. It has been replaced by a.withutility on theMonacoContextKeyServiceclass that uses Monaco utilities to create subcontexts so that the events don't bubble to the global context..withutility at all.ContextKeyServiceinterface from the mostly useless dummy implementation incore. This is a breaking change (extenders can no longerextends ContextKeyService), but it allows us to document the functionality of the methods. Previously each method was just annotated withShould be implemented elsewhere.How to test
Review checklist
Reminder for reviewers