Use tail decorations for problems in TreeWidget#10820
Merged
colin-grant-work merged 1 commit intoeclipse-theia:masterfrom Mar 3, 2022
Merged
Conversation
Member
vince-fugnitto
left a comment
There was a problem hiding this comment.
The changes work well for me 👍
There are still some key differences with vscode that we should probably align with if we feel that it represents a better behavior, namely:
- the priority or ordering of the tail-decorations
- the fact that the decoration with the highest priority or severity takes precedence over the entire decoration (we may argue that this limits the decorations and feel as though our approach is better)
theia
vscode:
vince-fugnitto
approved these changes
Mar 1, 2022
Member
vince-fugnitto
left a comment
There was a problem hiding this comment.
I'm happy with the changes 👍
The improvements I identified are general and should be handled when or if we revisit how decorations work and how can simplify them.
msujew
approved these changes
Mar 2, 2022
Member
msujew
left a comment
There was a problem hiding this comment.
The changes are looking good to me as well 👍
5018333 to
0fa8423
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What it does
FIxes: #3819
With an eye to making it easier to reuse code in plugin tree views (see this PR), this PR adjusts our current problem tree decorator to use tail decorations rather than icon overlays. That is more consistent with VSCode and also carries over into dot decorations of parents implemented in this PR.
The tabbar decorator also uses icon decorations for problems, which is not consistent with VSCode either, but is a completely separate subsystem, and currently the tabbar renderers don't support tail decorations.
How to test
Review checklist
Reminder for reviewers