Revert "Fix starting pseudoterminal (#10780)"#12098
Merged
thegecko merged 1 commit intoeclipse-theia:masterfrom Jan 23, 2023
Merged
Revert "Fix starting pseudoterminal (#10780)"#12098thegecko merged 1 commit intoeclipse-theia:masterfrom
thegecko merged 1 commit intoeclipse-theia:masterfrom
Conversation
Signed-off-by: robmor01 <Rob.Moran@arm.com> This reverts commit 363e521.
1 task
msujew
approved these changes
Jan 23, 2023
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
The changes work well for me 👍
- Running the test extension correctly brings up the pseudo terminal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: robmor01 Rob.Moran@arm.com
This reverts commit 363e521.
This reverts the previous fix for opening pseudoterminals as they now work as expected.
Supersedes: #12005
Fixes: #11858
Tested in browser and electron examples. Test steps from #12005 can be used (thanks @zvzuola)
cc @arekzaluski @zvzuola
What it does
How to test
Review checklist
Reminder for reviewers