Conversation
The commit downgrades the API version for compatibility reasons. The API is updated from `v1.68.1` to `v1.66.0`. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
requested review from
JonasHelming,
colin-grant-work,
msujew and
tsmaeder
|
cc @JonasHelming @tsmaeder @colin-grant-work @msujew Unfortunately it looks like What are your suggestions? |
|
@vince-fugnitto I just thought it would be a quick-win to get |
|
@vince-fugnitto : Thank you for catching this. We are actually also depending on 1.67 for our use cases. However, for the release tomorrow, we should go to 1.66 as you propose. We will back port the fix of the tab API to the community release once it is available to fix this issue. I propose to merge this and do the further discussion here: #12105 |
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
Looks good to me 👍
By the way, I won't perform a localization downgrade since everything we are using from the 1.68.1 version of nls.metadata.json is also available in language packs with version 1.66.2.
|
Merging this one so we can proceed with build tomorrow. |
This comment was marked as spam.
This comment was marked as spam.
5 participants
What it does
During today's dev meeting we discussed some concerns with bumping the API to a level that might cause issues due to stubbed
tabs-related API support. The initial idea was to downgrade the API fromv1.68.1tov1.67.0however that was incorrect asv1.67.0actually introduces tabs support. The API is therefore downgraded to a version which should not cause issues.How to test
Confirm CI passes.
Review checklist
Reminder for reviewers