Fix #12137: Webview that not implements a WebviewPanelSerializer should not restore automatically after reconnecting.#12138
Merged
msujew merged 1 commit intoeclipse-theia:masterfrom Feb 21, 2023
Conversation
…re automatically after reconnecting. Signed-off-by: huangyanyan <hyy215215@163.com>
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
The changes work well for me 👍 I would like the opinion of others however.
vince-fugnitto
approved these changes
Feb 21, 2023
This was referenced Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
https://code.visualstudio.com/api/extension-guides/webview#serialization
Webview that implements a WebviewPanelSerializer will be inserted to webviewRevivers.
So it is not necessary to show the error message if the webview isn't present in the webviewRevivers after reconnecting.
Fixed #12137
How to test
Check that the bugs descriped in #12137 no longer occur.
Review checklist
Reminder for reviewers