Ensure uniqueness of roots#12159
Merged
colin-grant-work merged 1 commit intoeclipse-theia:masterfrom Feb 10, 2023
Merged
Conversation
vince-fugnitto
approved these changes
Feb 7, 2023
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
LGTM 👍
I confirm that the updates properly handle the duplicate roots and falls on it's feet accordingly (by dismissing any duplicates).
colin-grant-work
deleted the
bugfix/repeated-folder-freezes-application
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #12155 by using a
Setto ensure uniqueness of roots when parsing a workspace file.How to test
Review checklist
Reminder for reviewers