Fire breakpoint events only if breakpoint metadata changes#12183
Merged
colin-grant-work merged 3 commits intoeclipse-theia:masterfrom Feb 23, 2023
Merged
Conversation
colin-grant-work
force-pushed
the
bugfix/redundant-breakpoint-events
branch
from
d8e83e3 to
27c5d5c
Compare
colin-grant-work
force-pushed
the
bugfix/redundant-breakpoint-events
branch
from
d6a881b to
7cd7c32
Compare
vince-fugnitto
approved these changes
Feb 23, 2023
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
I can confirm that the changes work as expected, and the errors no longer exist when a split editor is modified with breakpoints 👍
1 task
pisv
added a commit
to pisv/theia
that referenced
this pull request
Oct 8, 2023
…tion Fixes eclipse-theia#12546, which is a regression introduced by eclipse-theia#12183, by ensuring that `BreakpointManager.setMarkers` fires a `SourceBreakpointsChangeEvent` when `oldMarker === newMarker`, as there is no way to actually detect a change in this case.
1 task
pisv
added a commit
to pisv/theia
that referenced
this pull request
Nov 3, 2023
…tion Fixes eclipse-theia#12546, which is a regression introduced by eclipse-theia#12183, by ensuring that `BreakpointManager.setMarkers` fires a `SourceBreakpointsChangeEvent` when `oldMarker === newMarker`, as there is no way to actually detect a change in this case.
This was referenced Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #11878.
This PR fixes the stack overflow component of #11878 by ensuring that debug editor models provide the ID of breakpoints they believe have moved rather than retrieving the modified breakpoint from the breakpoint manager (whose state may have been updated in the meantime by a different model for the same editor) using location data and by ensuring that the breakpoint manager doesn't fire events when
setMarkersis called but no marker - breakpoint - metadata changes.How to test
Review checklist
Reminder for reviewers