#12203 Fixes VSCode modal inform message focus#12206
Merged
msujew merged 3 commits intoeclipse-theia:masterfrom Feb 22, 2023
Merged
#12203 Fixes VSCode modal inform message focus#12206msujew merged 3 commits intoeclipse-theia:masterfrom
msujew merged 3 commits intoeclipse-theia:masterfrom
Conversation
Fixes VSCode modal information message focus. Now focus will be on the first button, not on a background as it was before. Issue eclipse-theia#12203 Signed-off-by: Pavel Nikolaev <pnik@1c.ru>
msujew
reviewed
Feb 22, 2023
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
Hey @Zebsterpasha, thank you for your contribution :)
packages/plugin-ext/src/main/browser/dialogs/modal-notification.ts
Outdated
Show resolved
Hide resolved
packages/plugin-ext/src/main/browser/dialogs/modal-notification.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
vince-fugnitto
added
notifications
This was referenced Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes VSCode modal information message focus.
Now focus will be on the first button, not on a background as it was before.
Closes #12203
Closes #12204
Signed-off-by: Pavel Nikolaev pnik@1c.ru
What it does
Added a condition, if there is a first button on a Modal Message, it will be created by appendAcceptButton, other buttons will be created with createButton, except "Cancel".
How to test
Review checklist
Reminder for reviewers