QuickInput: First Element Fallback on Enter#12208
Merged
msujew merged 1 commit intoeclipse-theia:masterfrom Mar 9, 2023
Merged
QuickInput: First Element Fallback on Enter#12208msujew merged 1 commit intoeclipse-theia:masterfrom
msujew merged 1 commit intoeclipse-theia:masterfrom
Conversation
msujew
approved these changes
Feb 28, 2023
Member
msujew
left a comment
There was a problem hiding this comment.
Looks good to me 👍 I can confirm that the first element is always selected in case there's no explicit selection made programmatically.
Member
|
@FernandoAscencio Before I merge this PR, do you mind rebasing your PR onto the latest master? Just to confirm that your changes aren't the reason that the Ubuntu build pipeline is failing. |
Contributor
Author
Should be done |
Closes eclipse-theia#11979 Signed-off-by: FernandoAScencio <fernando.ascencio.cama@ericsson.com>
7fdc787 to
bb5739a
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Closes #11979
How to test
Some example menus that have been tested:
?or the help menu>or the command menuF5onAttach By Process IDNew Terminal (With Profile)...menuCtrl+K,Ctrl+Tor the Color Theme menu.Internal QuickPickcommand added in this request.Review checklist
Reminder for reviewers
Signed-Off-By: FernandoAscencio fernando.ascencio.cama@ericsson.com