Add boolean suppression DebugSessionOptions#12220
Merged
tsmaeder merged 2 commits intoeclipse-theia:masterfrom Mar 17, 2023
Merged
Add boolean suppression DebugSessionOptions#12220tsmaeder merged 2 commits intoeclipse-theia:masterfrom
tsmaeder merged 2 commits intoeclipse-theia:masterfrom
Conversation
Add options to suppress the debugging statusbar, toolbar and view. As well as the saving before starting a debugging session. Fixes eclipse-theia#12015 Contributed on behalf of STMicroelectronics
tsmaeder
reviewed
Mar 10, 2023
Member
tsmaeder
left a comment
There was a problem hiding this comment.
A couple of questions/suggestions
packages/debug/src/browser/debug-frontend-application-contribution.ts
Outdated
Show resolved
Hide resolved
packages/debug/src/browser/debug-frontend-application-contribution.ts
Outdated
Show resolved
Hide resolved
Member
|
There does not seem to be an option in the settings UI for |
tsmaeder
requested changes
Mar 16, 2023
Member
tsmaeder
left a comment
There was a problem hiding this comment.
I'm fine with the changes, but we need to decide whether the support for the saveOnStart preference should be in this PR or not. If not, could you please open an issue so we can track the problem?
Contributor
Author
|
I created #12319 for the follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Add options to suppress the debugging statusbar, toolbar and view.
As well as the saving before starting a debugging session.
Fixes #12015
Contributed on behalf of STMicroelectronics
Note:
Parent/child sessions are currently handled as followed:
I mostly went with two different approaches here due to the significance of the actions (saving vs graphical-only), but your input is welcome and i will gladly unify the approaches, when the "better" solution is identified.
How to test
It registers a few commands that start the "Launch Browser Backend" debug config with different options set.
Start Debuggingcommands. It says in parenthesis which options are enabled.Review checklist
Reminder for reviewers