vscode: provide error feedback for the vscode.open command#12284
Merged
vince-fugnitto merged 2 commits intoeclipse-theia:masterfrom Apr 10, 2023
Merged
vscode: provide error feedback for the vscode.open command#12284vince-fugnitto merged 2 commits intoeclipse-theia:masterfrom
vscode.open command#12284vince-fugnitto merged 2 commits intoeclipse-theia:masterfrom
Conversation
Partial implementation of 6568. Closes 5667 until there is closer implementation to VS Code. Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com> Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
FernandoAscencio
force-pushed
the
fa/vscOpenErrorMsg
branch
from
323fc9d to
e117891
Compare
vince-fugnitto
approved these changes
Apr 10, 2023
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
LGTM 👍 I confirmed that the message is correctly reported now to end-users and logged for additional information.
vince-fugnitto
changed the title
vscode.open command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Partial implementation of #6568.
Fixes #5667.
This commit implements error messages when a file is not found using the
vscode.opencommand.How to test
Some: Open Filecommand.Review checklist
Reminder for reviewers