Improve problem view performance#12408
Merged
msujew merged 3 commits intoeclipse-theia:masterfrom May 23, 2023
Merged
Conversation
hyy215
force-pushed
the
problem-performance
branch
from
960c6bb to
ede2c38
Compare
msujew
reviewed
Apr 17, 2023
packages/markers/src/browser/problem/problem-decorations-provider.ts
Outdated
Show resolved
Hide resolved
packages/markers/src/browser/problem/problem-decorations-provider.ts
Outdated
Show resolved
Hide resolved
packages/markers/src/browser/problem/problem-decorations-provider.ts
Outdated
Show resolved
Hide resolved
packages/markers/src/browser/problem/problem-composite-tree-node.ts
Outdated
Show resolved
Hide resolved
hyy215
force-pushed
the
problem-performance
branch
from
ede2c38 to
4f1516f
Compare
Signed-off-by: huangyanyan <hyy215215@163.com>
Signed-off-by: huangyanyan <hyy215215@163.com>
1. use protected instead of private 2. split the debounce part from the actual execution 3. increase delay to 50ms 4. use array to store markers Signed-off-by: huangyanyan <hyy215215@163.com>
msujew
force-pushed
the
problem-performance
branch
from
0292bf0 to
f2b6148
Compare
msujew
approved these changes
May 23, 2023
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
Thank you for the contribution, looks good to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixed #12407
If insert N nodes one by one, it maybe compare 1 + 2 + ... + (N - 2) + (N - 1) + N times.
How to test
Check that the bugs descriped in #12407.
Review checklist
Reminder for reviewers