[vscode][proposed] Stub onWillCreateEditSessionIdentity#12533
[vscode][proposed] Stub onWillCreateEditSessionIdentity#12533marcdumais-work merged 2 commits intomasterfrom
Conversation
e7b4dab to
94d275f
Compare
tsmaeder
left a comment
There was a problem hiding this comment.
Woudn't the simplest stub implementation just be an empty function function? No need for emitters and such.
vince-fugnitto
left a comment
There was a problem hiding this comment.
LGTM 👍
I confirmed that the builtin activates as expected, and the error is not thrown:
Activating extension 'Git (built-in)' failed: r.workspace.onWillCreateEditSessionIdentity is not a function
That's correct. I went a bit further than the simplest. I would not mind going with something simpler. |
94d275f to
f6cb9db
Compare
|
@tsmaeder as discussed I updated the 1st commit to use a separate Then I added commits on top to simplify the stub and tidy-up. |
|
I will resolve the conflicts locally after the other proposed API stubs are merged. |
|
@marcdumais-work it should be fine to rebase now 👍 |
This event was recently added to proposed API EditSessionIdentityProvider. For now we add a stub that will allow `vscode.git@1.77.0` and more recent to activate and be successfully used in Theia applications. Fixes #12521 Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
011429c to
7f631a3
Compare
Remove trailing space that trips the linter Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
What it does
This event was recently added to proposed API
EditSessionIdentityProvider. For now we add a stub that will allowvscode.git@1.77.0and more recent to activate and be successfully used in Theia applications.Fixes #12521
How to test
You can use the vscode.git 1.77.0 extensions below:
git-.zip
vscode.gitshould activate, not complaining aboutonWillCreateEditSessionIdentitynot existing. Built-ingitwill not ultimately work, unless@theia/gitis removed from the app - but that's no necessary for this PR)Review checklist
Reminder for reviewers