vscode: add ProfileContentHandler API stubbing#12535
Merged
vince-fugnitto merged 1 commit intomasterfrom May 18, 2023
Merged
Conversation
vince-fugnitto
added
vscode
alvsan09
approved these changes
May 18, 2023
Contributor
alvsan09
left a comment
alvsan09
left a comment
There was a problem hiding this comment.
I confirm the behavior is as expected and the fault is reproduced before the change 👍
The code LGTM as well !!
The commit adds stubbing for the proposed `ProfileContentHandler` VS Code API. The stubbing was necessary in order for the `vscode.configuration-editing` builtin to successfully activate. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/builtin-profileContentHandler
branch
from
ac2ce40 to
ffd2bc8
Compare
Contributor
|
The code looks good. I will quickly test this and approve if everything goes well. |
marcdumais-work
approved these changes
May 18, 2023
Contributor
marcdumais-work
left a comment
marcdumais-work
left a comment
There was a problem hiding this comment.
LGTM - works as expected. Thanks Vince!
tsmaeder
pushed a commit
to tsmaeder/theia
that referenced
this pull request
May 23, 2023
The commit adds stubbing for the proposed `ProfileContentHandler` VS Code API. The stubbing was necessary in order for the `vscode.configuration-editing` builtin to successfully activate. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Closes: #12520.
The pull-request adds a stubbing for the proposed
ProfileContentHandlerVS Code API.The API was necessary in order for
vscode.configuration-editing@1.77.0to successfully activate.How to test
vscode.configuration-editingbuiltin with1.77,0(configuration-editing-1.77.0.zip)theiaas a workspace.jsonfile - no errors should occur eitherReview checklist
Reminder for reviewers