fix: handle exception in WorkspaceDeleteHandler#12544
Merged
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom May 24, 2023
Merged
fix: handle exception in WorkspaceDeleteHandler#12544vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
Conversation
vince-fugnitto
added
quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Closes: #11908
This PR addresses issue #11908 where the method moveFileToTrash in the WorkspaceDeleteHandler class was not handling promise rejections correctly. The method has been updated to use await when calling fileService.delete(...) to ensure that rejections are caught properly.
How to test
Try deleting a file within the workspace. The file should move to trash successfully. Errors during deletion will display appropriate console error messages.
Review checklist
Reminder for reviewers