dialog: fix button order of ConfirmSaveDialog

[vladarama]

What it does

This PR fixes #12246 by making changes to the UI as per the defined conventions. It reorders the dialog buttons in the ConfirmSaveDialog to follow Cancel > Don't save > Save all sequence. This PR also makes sure that only one primary button is highlighted, which is the Save all button.

How to test

1. Remove AutoSave: File -> AutoSave
2. Create a new untitled file and make it dirty or make changes to an existing file
3. Attempt to close the app or close the workspace
4. Notice the dialog and test all three options ( Cancel > Don't save > Save all)
5. Make sure that all three options work on both browser and electron

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[msujew]

I'm not really sure that this is the correct approach to this issue. First off, we have some regressions with this:

I believe a refactoring of the ConfirmSaveDialog is in order. I'm not perfectly sure that the dialog should be in charge of actually executing the change. Instead, I would like to see it being decoupled from ConfirmDialog and returning some sort of enum:

enum ConfirmSaveResult {
  Cancel,
  Save,
  DontSave
}

That way we can actually save outside of the dialog and also make it easier to order the buttons, without needing to touch the ConfirmDialog at all.

[vladarama]

Yeah, you are right, refactoring ConfirmSaveDialog is the better approach. I'll get on it.

[msujew]

I think I led you down the wrong path. I've refactored this a bit more to reduce some of the duplication. Looks good to me now 👍

[vladarama]

Thanks for the changes Mark, I realize how much I overcomplicated some stuff.