open-editors: better styling and visible decorations#12598
Merged
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom Jun 15, 2023
Merged
open-editors: better styling and visible decorations#12598vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
Conversation
vince-fugnitto
approved these changes
Jun 8, 2023
Member
vince-fugnitto
left a comment
There was a problem hiding this comment.
LGTM 👍
I confirmed that the resizing behavior is correct, and there are no visible regressions from what I can tell.
This was referenced Feb 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
This PR fixes #10821 by changing the styling of the
open-editorsview to align more closely with the styling of theexploreritself. These changes include making the decorations always visible even when the view becomes too small and adding anellipsisoverflow to the filename and their paths.Demo:

How to test
Explorer View-> Make theOpen EditorsvisibleOpen Editorsview and observe the better stylingReview checklist
Reminder for reviewers