ui/ux: fix flickering icons when resizing explorer#12629
Merged
msujew merged 4 commits intoeclipse-theia:masterfrom Jul 5, 2023
Merged
ui/ux: fix flickering icons when resizing explorer#12629msujew merged 4 commits intoeclipse-theia:masterfrom
msujew merged 4 commits intoeclipse-theia:masterfrom
Conversation
msujew
reviewed
Jun 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
This PR closes #12615 by fixing the flickering of the toolbar icons when resizing the navigator. The issue was resolved by adding a new method called
noPointerOnHover. This method temporarily disables pointer events on the explorer view when the mouse enters it which prevents the flickering behavior and leads to a better user experience.Demo:

How to test
Explorerview and open a folder if none are open (File->Open Folder)Explorerview to make sure that it is not focusedReview checklist
Reminder for reviewers