vscode: support editor/title/run predefined entry#12637
Merged
JonasHelming merged 1 commit intoeclipse-theia:masterfrom Jun 27, 2023
Merged
vscode: support editor/title/run predefined entry#12637JonasHelming merged 1 commit intoeclipse-theia:masterfrom
JonasHelming merged 1 commit intoeclipse-theia:masterfrom
Conversation
Closes: eclipse-theia#9387 The commit adds the "editor/title/run" contribution point to menus Contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
vince-fugnitto
approved these changes
Jun 22, 2023
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
I can confirm that the new menu works as expected 👍
This was referenced Feb 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Adds a missing predefined entry in the menus
This enables the possibility to contribute menus to editor/title/run entry as defined in vscode.
Fixes #9387
Contributed on behalf of ST Microelectronics
How to test
Try to open a menu on any file except md file, one menu should be contributed by the extension. A second one will pop-up on any md file if the basic markdown extension is installed.
Update your
theiarepository to use this PRAny file should now also have an additional run menu entry, and the md files shall display a total of 2 o 4 menus with this extension depending if markdown extension is installed or not.
Review checklist
Reminder for reviewers