Skip to content

keybinding: Action Button Recenter#12675

Merged
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
FernandoAscencio:fa/keybindActionRecenter
Jul 18, 2023
Merged

keybinding: Action Button Recenter#12675
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
FernandoAscencio:fa/keybindActionRecenter

Conversation

@FernandoAscencio
Copy link
Contributor

After Editing keybinding, the reset button is half hidden.
This commit should properly center the keybinding action buttons.

What it does

BEFORE
image
image

AFTER
image
image

How to test

  1. Open Theia
  2. Change a keybinding.
  3. Check that the reset button to default button is half hidden

Review checklist

Reminder for reviewers

After Editing keybindding the reset button is half hidden.
This commit should properly center the keybidding action buttons.

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
@vince-fugnitto vince-fugnitto added keybindings issues related to keybindings ui/ux issues related to user interface / user experience labels Jul 6, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated stylings look good to me 👍

@vince-fugnitto vince-fugnitto merged commit 41c6d9f into eclipse-theia:master Jul 18, 2023
@vince-fugnitto vince-fugnitto deleted the fa/keybindActionRecenter branch July 18, 2023 16:55
@vince-fugnitto vince-fugnitto added this to the 1.40.0 milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

keybindings issues related to keybindings ui/ux issues related to user interface / user experience

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants