[vscode] Add proposed dropMetadata API#12736
Merged
Conversation
5133e3a to
813ee11
Compare
Member
Member
Author
|
@tsmaeder I assume that this is an untested combination of #12065 and #12125. Since both PRs were submitted at similar times, I assume that the latter one didn't include the former yet, so I didn't notice the strange behavior during testing. And no, this isn't desired behavior. I believe that vscode has a special mode (activated via However, fixing that is imo out of scope for this PR. |
Member
|
I've opened #12748 |
tsmaeder
approved these changes
Jul 24, 2023
Member
tsmaeder
left a comment
There was a problem hiding this comment.
Since the observed weird behavior cannot possibly be due to the changes in this PR, this looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Closes #12632
This PR adds the groundworks for supporting the proposed API. Note that while the API is supported on a type level, our current monaco version isn't able to actually make use of the changes. I've annotated all places in the code with
@monaco-upliftso that any contributor can improve on this behavior once we have performed the uplift to^1.79.0.How to test
There isn't really anything to test, no behavior should have changed. Confirm that the changes in #12125 still work as expected.
Review checklist
Reminder for reviewers