[vscode] support TaskPresentationOptions close#12749
Merged
tsmaeder merged 1 commit intoeclipse-theia:masterfrom Jul 25, 2023
Merged
[vscode] support TaskPresentationOptions close#12749tsmaeder merged 1 commit intoeclipse-theia:masterfrom
tsmaeder merged 1 commit intoeclipse-theia:masterfrom
Conversation
rschnekenbu
force-pushed
the
issues/12611
branch
from
452ec93 to
43b3de3
Compare
rschnekenbu
changed the title
2 tasks
Member
|
@rschnekenbu could you resolve the conflict, please? |
Contributor
Author
|
@tsmaeder, sure! |
* Adds close to the TaskPresentationOptions * Checks when task is finished if terminal shall be closed Contributed on behalf of STMicroelectronics
rschnekenbu
force-pushed
the
issues/12611
branch
from
43b3de3 to
6dab367
Compare
tsmaeder
approved these changes
Jul 25, 2023
Member
tsmaeder
left a comment
tsmaeder
left a comment
There was a problem hiding this comment.
Looks good to me. Was able to test after installing ruby/rake.
Member
|
Let's wait for the tests to finish before we merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Adds the close property to TaskPresentationOptions
This enables the possibility to close the terminal once the task is finished.
Fixes #12611
Contributed on behalf of ST Microelectronics
How to test
Copy the content of this archive at the root of your workspace:
workspace-test.zip. It contains several tasks that can be identified by the sample extension. In the extension, the build tasks are supposed to close the terminal after the task is finished (
closeset totrue) whereas the terminal should remain on completion for other tasks like test tasks.On
mastertheia, the terminal always remain after the tasks are finished (this is also the default behavior after the patch whencloseis not defined.). The extension is written so the tasks are configured differently if they are build tasks or any other kind of tasks. This does not do any difference onmaster, as the close property is not known.Switch to this PR and run the same tests. The terminal will close for the build tasks, and remain open for reuse for the other tasks like test tasks.
Review checklist
Reminder for reviewers