navigator: handle middle-click behavior#12783
Merged
vince-fugnitto merged 9 commits intoeclipse-theia:masterfrom Aug 3, 2023
Merged
navigator: handle middle-click behavior#12783vince-fugnitto merged 9 commits intoeclipse-theia:masterfrom
vince-fugnitto merged 9 commits intoeclipse-theia:masterfrom
Conversation
Member
vince-fugnitto
left a comment
There was a problem hiding this comment.
I noticed a bug when opening multiple editors using middle-click where we would incorrectly paste the clipboard into the editor (Linux):
- start the application
- confirm that content exists in the clipboard
- open multiple editors from the explorer using middle-click
- confirm the bug exists where clipboard content is being pasted into previous editors
vince-fugnitto
approved these changes
Aug 2, 2023
Member
vince-fugnitto
left a comment
There was a problem hiding this comment.
I confirmed that the changes work as expected 👍
- middle-click in the explorer, and other trees (ex: siw) works as expected
- middle-clicking collapsible nodes correctly expands/collapses nodes
- the auto-scroll behavior was fixed (confirmed on Firefox)
Member
|
I'll merge, we can catch any potential regressions throughout the month if necessary. |
This was referenced Aug 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #12762
Fixes: #12788
This PR handles the middle-click button behavior in various tree-widgets, such as the
explorer,search-in-workspace,references... Like in VS Code, selecting a file using the middle-button will open that file as an open-editor instead of simply selecting it. This achieves the same functionality as double-clicking on a file, but it is faster.Demo:

How to test
Explorer/Search-in-workspace/SCM/... viewsReview checklist
Reminder for reviewers