getting-started: fix checkbox overlapping with other content for small viewports#12825
Merged
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom Aug 21, 2023
Merged
Conversation
This commit adds a className and styling to the main div containing the getting-started content and the preferences which fixes the overlapping checkbox for small viewports. Signed-off-by: Vlad Arama <vlad.arama@ericsson.com>
vince-fugnitto
added
getting-started
vince-fugnitto
approved these changes
Aug 15, 2023
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
I confirmed the resizing behavior is much better compared to master 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #12822
This PR fixes the issue with the getting-started preference checkbox overlapping with other content for small viewports. It achieves this by adding styling to the main getting-started container which includes:
justify-content: space-between.Before:
After:
How to test
Ctrl+Shift+p) and search forwelcome.Review checklist
Reminder for reviewers