Fix plugin menu icon background on hover#12827
Merged
Conversation
msujew
added
plug-in system
kittaakos
approved these changes
Aug 14, 2023
vince-fugnitto
approved these changes
Aug 15, 2023
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
LGTM 👍 I can confirm the icon display persists when hovering
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Closes #12826
Replaces the css rule on the icon element with a
::beforeelement that emulates the same behavior. That leaves the background attribute on the icon element free to use ourselves.How to test
Follow the instructions in #12826 to ensure that the behavior has been fixed.
Review checklist
Reminder for reviewers