Remove baseUrl from tsconfigs#12981
Merged
tortmayr merged 1 commit intoeclipse-theia:masterfrom Nov 22, 2023
Merged
Conversation
According to the [tsconfig doc](https://www.typescriptlang.org/tsconfig#baseUrl): This feature was designed for use in conjunction with AMD module loaders in the browser, and is not recommended in any other context. As of TypeScript 4.1, baseUrl is no longer required to be set when using paths. In addition, this options does not work well with auto import resolving of Typescript-LSPs (i.e. Theia/VS Code). Auto import might resolves to a statement starting with `src` ( e.g. ` import { ChannelMultiplexer } from 'src/common/message-rpc/channel';`) which does not work well with inversify and can result in runtime errors Most of the packages don't use it anyways. This PR removes the remaining usages and adapts `src` imports.
tortmayr
force-pushed
the
tortmayr/tsconfig
branch
from
155013e to
f4ebb3b
Compare
martin-fleck-at
approved these changes
Nov 22, 2023
Contributor
martin-fleck-at
left a comment
martin-fleck-at
left a comment
There was a problem hiding this comment.
Looks good to me and I couldn't find any other places where the baseUrl is defined. CI is also happy so let's get this merged! Thank you, Tobias!
ivy-cst
added a commit
to axonivy/inscription-client
that referenced
this pull request
Nov 24, 2023
ivy-cst
added a commit
to axonivy/process-editor
that referenced
this pull request
Nov 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
According to the tsconfig doc:
This feature was designed for use in conjunction with AMD module loaders in the browser, and is not recommended in any other context. As of TypeScript 4.1, baseUrl is no longer required to be set when using paths.
In addition, this options does not work well with auto import resolving of Typescript-LSPs (i.e. Theia/VS Code). Auto import might resolves to a statement starting with
src( e.g.import { ChannelMultiplexer } from 'src/common/message-rpc/channel';) which does not work well with inversify and can result in runtime errors.Most of the packages don't use it anyways. This PR removes the remaining usages and adapts
srcimports.Contributed on behalf of STMicroelectronics
How to test
Building & running the example application should still work as before
Follow-ups
Review checklist
Reminder for reviewers