Ensure ApplicationShellOptions are properly used for shell init#12983
Merged
martin-fleck-at merged 1 commit intomasterfrom Oct 11, 2023
Merged
Ensure ApplicationShellOptions are properly used for shell init#12983martin-fleck-at merged 1 commit intomasterfrom
martin-fleck-at merged 1 commit intomasterfrom
Conversation
tortmayr
reviewed
Oct 11, 2023
| @@ -307,15 +307,15 @@ export class ApplicationShell extends Widget { | |||
| this.options = { | |||
Contributor
There was a problem hiding this comment.
IMO we could resolve the options directly in the constructor. There is no need to this in postConstruct because we don't rely on any injected services. This would also remove the need to expose the partial options as protected property.
Contributor
Author
There was a problem hiding this comment.
Thank you for the having a look! Good point, I updated the PR with this simplification.
martin-fleck-at
force-pushed
the
issues/12982
branch
from
57fcc30 to
1a922ed
Compare
tortmayr
approved these changes
Oct 11, 2023
Contributor
tortmayr
left a comment
tortmayr
left a comment
There was a problem hiding this comment.
Thanks for the quick fix. Change works great and custom shell options are now properly picked up and used for shell init. 👍🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Ensure ApplicationShellOptions are properly used for shell init
Fixes #12982
How to test
rebind(ApplicationShellOptions).toConstantValue(<ApplicationShell.Options>{ leftPanel: { initialSizeRatio: 0.5 } });or replace the binding in Theia with something that has values (https://github.com/eclipse-theia/theia/blob/master/packages/core/src/browser/frontend-application-module.ts#L163)Follow-ups
None.
Review checklist
Reminder for reviewers