Implement EnvironmentVariableMutatorOptions API.#12984
Merged
tsmaeder merged 1 commit intoeclipse-theia:masterfrom Oct 19, 2023
Merged
Implement EnvironmentVariableMutatorOptions API.#12984tsmaeder merged 1 commit intoeclipse-theia:masterfrom
tsmaeder merged 1 commit intoeclipse-theia:masterfrom
Conversation
…12941 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Member
Author
|
Here's the extension: and here's the source: |
martin-fleck-at
approved these changes
Oct 13, 2023
Contributor
martin-fleck-at
left a comment
There was a problem hiding this comment.
Thank you @tsmaeder! I checked the code with your extension and everything works as expected. Values are properly handled based on their mutator options, meaning that in our case if you have applyAtProcessCreation set to false explicitly, they will not be available and applyAtShellIntegration is only stubbed/ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Implements options when mutating
EnvironmentVariableCollections. Since Theia does not support shell integration scripts, one of the options is stubbed. See the related issue for details.Fixes #12941
Contributed on behalf of STMicroelectronics
How to test
Install the attached extension. It exercises the various cases like so:
After startup, open a terminal. My expectation is that THE
MUTATED_DEFAULTandMUTATED_TRUEare set in the terminal shell.Follow-ups
If we ever decide to implement shell integration scripts, we need to honor the corresponding flag.
Review checklist
Reminder for reviewers