Merged
Conversation
vince-fugnitto
added
quality
Member
Author
|
The |
vince-fugnitto
force-pushed
the
vf/yarn-upgrade-10-23
branch
from
53a268b to
758052b
Compare
Member
Author
|
The 3PP licenses are finally approved and CI is passing if anyone is interested in performing a review :) |
msujew
approved these changes
Nov 20, 2023
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
Thanks Vince, looks good to me 👍
vince-fugnitto
force-pushed
the
vf/yarn-upgrade-10-23
branch
from
758052b to
97145de
Compare
The commit performs a `yarn upgrade` of the framework to better represent what downstream applications pull with our version ranges, and to resolve known security vulnerabilities which were pulled by our lockfile. The changes also make sure that our declared ranges for dependencies are correct and fixes any compilation errors. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/yarn-upgrade-10-23
branch
from
97145de to
823a5ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request performs a
yarn upgradeof the framework to better represent what downstream applications pull with our version ranges, and to resolve known security vulnerabilities which were pulled by our lockfile. The changes also make sure that our declared ranges for dependencies are correct and fixes any compilation errors.How to test
yarn auditdoes not output vulnerabilitiesFollow-ups
Review checklist
Reminder for reviewers