fix: allow all listener to be executed for AsyncEmitter#13079
Merged
tortmayr merged 1 commit intoeclipse-theia:masterfrom Nov 28, 2023
Merged
fix: allow all listener to be executed for AsyncEmitter#13079tortmayr merged 1 commit intoeclipse-theia:masterfrom
tortmayr merged 1 commit intoeclipse-theia:masterfrom
Conversation
tortmayr
approved these changes
Nov 21, 2023
Contributor
tortmayr
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me.
AsyncEmitters now work as expected and all listener callback are invoked when an event is fired even if some of them don't use Event.waitUntil in the callback.
Nice catch!
Contributor
|
@tortmayr Thank you for the reivew, do you want to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
With AsyncEmitters, if a listener callback does not call
event.waitUntil, other listeners that are registered after this one will fail to be called due to early loop termination.How to test
Register two separate callbacks without
waitUntilforFileService.onDidRunUserOperationor any otherAsyncEmitter.eventand fire an event. Verify that both callbacks are called correctly.Review checklist
Reminder for reviewers