Merged
Conversation
The commit updates the baseline when running our `license:check` against dash-licenses. The baseline was updated to: - remove entries which have been approved - add `normalize-package-data` which is still under review The update was necessary for a clean baseline to identify actual issues with dependencies going forward. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request updates our
dependency-check-baseline.jsonto reflect the latest state of the repository.The updates include:
normalize-package-dataas a dependency which is currently under-review (the dependency was manually verified as being license compatible)The changes are necessary to ensure the
license:checkpasses and we can better identify actual problems with dependencies going forward.How to test
3PP License CheckCI step is passing (can runyarn license:checklocally as well)Follow-ups
Review checklist
Reminder for reviewers