Use app shell methods for expand / collapse for toggle terminal command#13131
Merged
JonasHelming merged 4 commits intoeclipse-theia:masterfrom Dec 14, 2023
Merged
Conversation
Signed-off-by: Bryan Chen <Bryan.Chen2@microchip.com>
bryanchenmchp
changed the title
tortmayr
approved these changes
Dec 13, 2023
Contributor
tortmayr
left a comment
tortmayr
left a comment
There was a problem hiding this comment.
LGTM and works as expected! Thanks!
Contributor
|
@bryanchenmchp There is a conflict in the changelog that needs to be resolved before we can merge this |
Contributor
Author
|
Updated changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes the
toggleTerminal()method to use the app shell expand/collapse methods.Resolves #13129
How to test
yarn electron buildand thenyarn electron startReview checklist
Reminder for reviewers