Skip to content

Update nls metadata for vscode API 1.84.2#13200

Merged
vince-fugnitto merged 2 commits intomasterfrom
msujew/update-nls-metadata-1.84.2
Dec 20, 2023
Merged

Update nls metadata for vscode API 1.84.2#13200
vince-fugnitto merged 2 commits intomasterfrom
msujew/update-nls-metadata-1.84.2

Conversation

@msujew
Copy link
Member

@msujew msujew commented Dec 20, 2023

What it does

Related to #13198

How to test

CI is green, translations work as expected.

Review checklist

Reminder for reviewers

@msujew msujew added the localization issues related to localization/internalization/nls label Dec 20, 2023
@tsmaeder
Copy link
Member

@msujew I guess this should go into the release? Could you fix the linter sadness, please?

@msujew
Copy link
Member Author

msujew commented Dec 20, 2023

@tsmaeder Thanks, my local build didn't correctly flag the error. It should work now (hopefully).

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vince-fugnitto vince-fugnitto merged commit ea0db7a into master Dec 20, 2023
@vince-fugnitto vince-fugnitto deleted the msujew/update-nls-metadata-1.84.2 branch December 20, 2023 19:35
@github-actions github-actions bot added this to the 1.45.0 milestone Dec 20, 2023
@vince-fugnitto vince-fugnitto modified the milestone: 1.45.0 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

localization issues related to localization/internalization/nls

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants