-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Allow filerting backticks in AI code completion #14777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
packages/ai-code-completion/src/browser/code-completion-postprocessor.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| // ***************************************************************************** | ||
| // Copyright (C) 2024 EclipseSource GmbH. | ||
| // | ||
| // This program and the accompanying materials are made available under the | ||
| // terms of the Eclipse Public License v. 2.0 which is available at | ||
| // http://www.eclipse.org/legal/epl-2.0. | ||
| // | ||
| // This Source Code may also be made available under the following Secondary | ||
| // Licenses when the conditions for such availability set forth in the Eclipse | ||
| // Public License v. 2.0 are satisfied: GNU General Public License, version 2 | ||
| // with the GNU Classpath Exception which is available at | ||
| // https://www.gnu.org/software/classpath/license.html. | ||
| // | ||
| // SPDX-License-Identifier: EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0 | ||
| // ***************************************************************************** | ||
|
|
||
| import { enableJSDOM } from '@theia/core/lib/browser/test/jsdom'; | ||
| let disableJSDOM = enableJSDOM(); | ||
| import { FrontendApplicationConfigProvider } from '@theia/core/lib/browser/frontend-application-config-provider'; | ||
| FrontendApplicationConfigProvider.set({}); | ||
|
|
||
| import { expect } from 'chai'; | ||
| import { DefaultCodeCompletionPostProcessor } from './code-completion-postprocessor'; | ||
|
|
||
| disableJSDOM(); | ||
|
|
||
| describe('CodeCompletionAgentImpl', () => { | ||
| let codeCompletionProcessor: DefaultCodeCompletionPostProcessor; | ||
| before(() => { | ||
| disableJSDOM = enableJSDOM(); | ||
| codeCompletionProcessor = new DefaultCodeCompletionPostProcessor(); | ||
| }); | ||
|
|
||
| after(() => { | ||
| // Disable JSDOM after all tests | ||
| disableJSDOM(); | ||
| }); | ||
|
|
||
| describe('stripBackticks', () => { | ||
|
|
||
| it('should remove surrounding backticks and language (TypeScript)', () => { | ||
| const input = '```TypeScript\nconsole.log(\"Hello, World!\");```'; | ||
| const output = codeCompletionProcessor.stripBackticks(input); | ||
| expect(output).to.equal('console.log("Hello, World!");'); | ||
| }); | ||
|
|
||
| it('should remove surrounding backticks and language (md)', () => { | ||
| const input = '```md\nconsole.log(\"Hello, World!\");```'; | ||
| const output = codeCompletionProcessor.stripBackticks(input); | ||
| expect(output).to.equal('console.log("Hello, World!");'); | ||
| }); | ||
|
|
||
| it('should remove all text after second occurrence of backticks', () => { | ||
| const input = '```js\nlet x = 10;\n```\nTrailing text should be removed```'; | ||
| const output = codeCompletionProcessor.stripBackticks(input); | ||
| expect(output).to.equal('let x = 10;'); | ||
| }); | ||
|
|
||
| it('should return the text unchanged if no surrounding backticks', () => { | ||
| const input = 'console.log(\"Hello, World!\");'; | ||
| const output = codeCompletionProcessor.stripBackticks(input); | ||
| expect(output).to.equal('console.log("Hello, World!");'); | ||
| }); | ||
|
|
||
| it('should remove surrounding backticks without language', () => { | ||
| const input = '```\nconsole.log(\"Hello, World!\");```'; | ||
| const output = codeCompletionProcessor.stripBackticks(input); | ||
| expect(output).to.equal('console.log("Hello, World!");'); | ||
| }); | ||
|
|
||
| it('should handle text starting with backticks but no second delimiter', () => { | ||
| const input = '```python\nprint(\"Hello, World!\")'; | ||
| const output = codeCompletionProcessor.stripBackticks(input); | ||
| expect(output).to.equal('print("Hello, World!")'); | ||
| }); | ||
|
|
||
| }); | ||
| }); |
48 changes: 48 additions & 0 deletions
48
packages/ai-code-completion/src/browser/code-completion-postprocessor.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // ***************************************************************************** | ||
| // Copyright (C) 2024 EclipseSource GmbH. | ||
| // | ||
| // This program and the accompanying materials are made available under the | ||
| // terms of the Eclipse Public License v. 2.0 which is available at | ||
| // http://www.eclipse.org/legal/epl-2.0. | ||
| // | ||
| // This Source Code may also be made available under the following Secondary | ||
| // Licenses when the conditions for such availability set forth in the Eclipse | ||
| // Public License v. 2.0 are satisfied: GNU General Public License, version 2 | ||
| // with the GNU Classpath Exception which is available at | ||
| // https://www.gnu.org/software/classpath/license.html. | ||
| // | ||
| // SPDX-License-Identifier: EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0 | ||
| // ***************************************************************************** | ||
|
|
||
| import { inject, injectable } from '@theia/core/shared/inversify'; | ||
| import { PreferenceService } from '@theia/core/lib/browser'; | ||
| import { PREF_AI_INLINE_COMPLETION_STRIP_BACKTICKS } from './ai-code-completion-preference'; | ||
|
|
||
| export interface CodeCompletionPostProcessor { | ||
| postProcess(text: string): string; | ||
| } | ||
| export const CodeCompletionPostProcessor = Symbol('CodeCompletionPostProcessor'); | ||
|
|
||
| @injectable() | ||
| export class DefaultCodeCompletionPostProcessor { | ||
|
|
||
| @inject(PreferenceService) | ||
| protected readonly preferenceService: PreferenceService; | ||
|
|
||
| public postProcess(text: string): string { | ||
| if (this.preferenceService.get<boolean>(PREF_AI_INLINE_COMPLETION_STRIP_BACKTICKS, true)) { | ||
| return this.stripBackticks(text); | ||
| } | ||
| return text; | ||
| } | ||
|
|
||
| public stripBackticks(text: string): string { | ||
| if (text.startsWith('```')) { | ||
| // Remove the first backticks and any language identifier | ||
| const startRemoved = text.slice(3).replace(/^\w*\n/, ''); | ||
| const secondBacktickIndex = startRemoved.indexOf('```'); | ||
| return secondBacktickIndex !== -1 ? startRemoved.slice(0, secondBacktickIndex).trim() : startRemoved.trim(); | ||
| } | ||
| return text; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we use lastIndexOf ?
This would better catch this case:
```\nFoo```Bar```FooBar```I would expect the result to be:
Foo```Bar```FooBarbut in your code I assume it would be:
Foo