[vscode] Remove duplicate declaration for DocumentDropEdit#15126
Merged
rschnekenbu merged 1 commit intomasterfrom Mar 6, 2025
Merged
[vscode] Remove duplicate declaration for DocumentDropEdit#15126rschnekenbu merged 1 commit intomasterfrom
rschnekenbu merged 1 commit intomasterfrom
Conversation
tsmaeder
approved these changes
Mar 6, 2025
github-project-automation
bot
moved this from Waiting on reviewers
to Needs merge
in PR Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Removes a duplicate in theia.d.ts file. DocumentDropEdit was improved when a proposed API was made public, but a duplicate was introduced in Theia rather than updating the existing one. This PR removes the duplicate. This fixes the status report for Theia VScode compatibility (https://eclipse-theia.github.io/vscode-theia-comparator/status.html)
It also mark the DocumentDropEditProvider#resolveDocumentDropEdit as stubbed as there is currently no implementation backing this optional field.
Also, as a note, the DocumentDropEditProviders do not behave as they are supposed to do. The upgrade to monaco editor did remove some functional code. see language-main changes in https://github.com/eclipse-theia/theia/pull/14737/files#diff-c3f11c10237ecdc571f7990062c887b7a1ab822927da02db28fedfe1e69fc4a9
fixes #15123
How to test
Nothing to test, as code was working or only documentation update. Only the report is now fixed.
Original
After patch
Follow-ups
Implementation / restore DocumentDropEditProvider (see #15058)
Breaking changes
Attribution
Contributed on behalf of STMicroelectronics
Review checklist
Reminder for reviewers