Skip to content

Ensure valid editor constructed before attempting to use editor services #15238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colin-grant-work merged 6 commits into from
Mar 28, 2025
Merged

Ensure valid editor constructed before attempting to use editor services #15238

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e0dc27d
Ensure editor created before services used
colin-grant-work Mar 20, 2025
6d35a44
Lint
colin-grant-work Mar 25, 2025
118daf9
Close editor on successful action, not any change
colin-grant-work Mar 25, 2025
e2cf80c
Update DirtyDiffWidget change model when changes change
colin-grant-work Mar 25, 2025
d809c93
Update headings; jump in main editor; close if no changes
colin-grant-work Mar 26, 2025
fc8aa2d
Use the global instantiation service on disposal
colin-grant-work Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use the global instantiation service on disposal
  • Loading branch information
@colin-grant-work
colin-grant-work committed Mar 27, 2025
commit fc8aa2dcd741759b50b136141eb2e96b67545f2d
8 changes: 7 additions & 1 deletion packages/monaco/src/browser/monaco-editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ import { ILanguageConfigurationService } from '@theia/monaco-editor-core/esm/vs/
import { ILanguageFeaturesService } from '@theia/monaco-editor-core/esm/vs/editor/common/services/languageFeatures';
import * as objects from '@theia/monaco-editor-core/esm/vs/base/common/objects';
import { Selection } from '@theia/editor/lib/browser/editor';
import { IHoverService } from '@theia/monaco-editor-core/esm/vs/platform/hover/browser/hover';
import { IHoverService, WorkbenchHoverDelegate } from '@theia/monaco-editor-core/esm/vs/platform/hover/browser/hover';
import { setHoverDelegateFactory } from '@theia/monaco-editor-core/esm/vs/base/browser/ui/hover/hoverDelegateFactory';
import { MonacoTextModelService } from './monaco-text-model-service';

export type ServicePair<T> = [ServiceIdentifier<T>, T];
Expand Down Expand Up @@ -155,6 +156,11 @@ export class MonacoEditor extends MonacoEditorServices implements TextEditor {
...MonacoEditor.createReadOnlyOptions(document.readOnly),
...options
}, override));
// Ensure that a valid InstantiationService is responsible for creating hover delegates when the InstantiationService for this widget is disposed.
// Cf. https://github.com/eclipse-theia/theia/issues/15102
this.toDispose.push(Disposable.create(() => setHoverDelegateFactory((placement, enableInstantHover) =>
StandaloneServices.get(IInstantiationService).createInstance(WorkbenchHoverDelegate, placement, enableInstantHover, {})
)));
this.addHandlers(this.editor);
}

Expand Down
Loading