Skip to content

Add support for the new vscode.lm.registerMcpServerDefinitionProvider API #15755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eneufeld merged 2 commits into from
Jun 5, 2025
Merged

Add support for the new vscode.lm.registerMcpServerDefinitionProvider API #15755

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ac8ce8
Add support for the new vscode.lm.registerMcpServerDefinitionProvider…
eneufeld Jun 5, 2025
57672f3
Apply suggestions from code review
eneufeld Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: Philip Langer <planger@eclipsesource.com>
  • Loading branch information
@eneufeld @planger
eneufeld and planger authored Jun 5, 2025
commit 57672f37b6c71e4b5945df1975103cdb20daa3b5
1 change: 0 additions & 1 deletion packages/plugin-ext/src/main/browser/lm-main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ export class McpServerDefinitionRegistryMainImpl implements McpServerDefinitionR

$registerMcpServerDefinitionProvider(handle: number, name: string): void {
this.providers.set(handle, name);
// Trigger initial load of server definitions
this.loadServerDefinitions(handle);
}

Expand Down
3 changes: 1 addition & 2 deletions packages/plugin-ext/src/plugin/lm-ext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ export class LmExtImpl implements McpServerDefinitionRegistryExt {

this.proxy.$registerMcpServerDefinitionProvider(handle, id);

// Listen for changes from the provider
if (provider.onDidChangeMcpServerDefinitions) {
const changeListener = provider.onDidChangeMcpServerDefinitions(() => {
this.proxy.$onDidChangeMcpServerDefinitions(handle);
Expand Down Expand Up @@ -89,7 +88,7 @@ export class LmExtImpl implements McpServerDefinitionRegistryExt {
return [];
}

return definitions.map(this.convertToDto);
return definitions.map(def => this.convertToDto(def));
} catch (error) {
this.logger.error('Error providing MCP server definitions:', error);
return [];
Expand Down
2 changes: 0 additions & 2 deletions packages/plugin-ext/src/plugin/plugin-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1346,7 +1346,6 @@ export function createAPIFactory(
}
};

// Process MCP server definition provider contributions
const mcpContributions = plugin.rawModel.contributes && plugin.rawModel.contributes.mcpServerDefinitionProviders || [];
lmExt.registerMcpContributions(mcpContributions);

Expand All @@ -1367,7 +1366,6 @@ export function createAPIFactory(
},
/** @stubbed LanguageModelTool */
tools: [],
/** MCP Server Definition Provider */
registerMcpServerDefinitionProvider(id: string, provider: any): theia.Disposable {
return lmExt.registerMcpServerDefinitionProvider(id, provider);
}
Expand Down
Loading