fix: restore toolbar default items#15878
Merged
sgraband merged 1 commit intoeclipse-theia:masterfrom Jun 26, 2025
Merged
Conversation
5 tasks
sgraband
approved these changes
Jun 25, 2025
Contributor
sgraband
left a comment
There was a problem hiding this comment.
Thank you for this contribution! LGTM and works great! 👍
Especially nice that you now get notified, when the config does not work!
- properly restore the toolbar items in the storage provider from the default factory and ensure to write to the config file - ensure the defaults are restored on startup in case there is no config file yet - in case the config file was corrupted, allow the user to restore the default toolbar items via an action in the error message popup - chore: remove unused injections in ToolbarCommandContribution Fixes eclipse-theia#15231
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #15231
How to test
toolbar.jsonconfig file reflects the default configuration (open via "Customize Toolbar (Open JSON)" command in the context menutoolbar.jsonconfig fileFollow-ups
x
Breaking changes
Attribution
Review checklist
Reminder for reviewers