Improve handling of terminal manager preferences & element deletion#16827
Merged
colin-grant-work merged 7 commits intomasterfrom Jan 20, 2026
Merged
Improve handling of terminal manager preferences & element deletion#16827colin-grant-work merged 7 commits intomasterfrom
colin-grant-work merged 7 commits intomasterfrom
Conversation
3 tasks
colin-grant-work
force-pushed
the
bugfix/terminal-manager-enablement
branch
from
6e870dd to
546b88f
Compare
ndoschek
reviewed
Jan 19, 2026
Member
ndoschek
left a comment
ndoschek
left a comment
There was a problem hiding this comment.
Thanks a lot for this great improvement Colin!
The switch between the two modes is incredibly smooth and works great!
Everything works as expected, I also repeated my test cases from the linked PR and everything looks great to me!
I just have a minor comment inline and also the linting is failing, but this should be an easy fix I think.
Would be great if you could have a quick look there! TIA!
Comment on lines
+42
to
+43
| @inject(PreferenceService) | ||
| protected readonly preferenceService: PreferenceService; |
Member
There was a problem hiding this comment.
minor: as we also inject the TerminalManagerPreferences proxy above, we could skip this inject here as we can call ready and on onPreferenceChanged also on the proxy.
colin-grant-work
force-pushed
the
bugfix/terminal-manager-enablement
branch
from
d29b724 to
ef7bafd
Compare
ndoschek
approved these changes
Jan 20, 2026
Member
ndoschek
left a comment
ndoschek
left a comment
There was a problem hiding this comment.
Thanks for the update, LGTM 🎉
github-project-automation
bot
moved this from Waiting on reviewers
to Needs merge
in PR Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #16759
How to test
terminal.grouping.modetotabbedterminal.grouping.modetotreeand open the Terminal Manager view.tabbedBehaviors implemented in #16807 should be retained, and selection transfer should work correctly even when the first of two pages is selected.
Follow-ups
Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers