Skip to content

fix: handle notification timeout correctly when set to 0#16849

Merged
ndoschek merged 1 commit intomasterfrom
nd/fix-notification-timeout
Jan 23, 2026
Merged

fix: handle notification timeout correctly when set to 0#16849
ndoschek merged 1 commit intomasterfrom
nd/fix-notification-timeout

Conversation

@ndoschek
Copy link
Member

@ndoschek ndoschek commented Jan 20, 2026

What it does

  • Fix timeout logic to properly handle explicit timeout of 0
  • Change condition from falsy check to undefined check to preserve 0 value if set explicitly
  • Add unit tests for getTimeout method covering various timeout scenarios
  • Add sample commands demonstrating persistent and vanishing notifications

How to test

  • Test the different commands with either 0ms, 500ms or default notification timeout:
    • Sample Persistent Notification (No Timeout)
    • Sample Vanishing Notification (500ms Timeout)
    • Test Positive Integer (default timeout: 30000ms, unless overridden in the settings notification.timeout)

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Contributed on behalf of STMicroelectronics

Review checklist

Reminder for reviewers

- Fix timeout logic to properly handle explicit timeout of 0
- Change condition from falsy check to undefined check to preserve 0 value if set explicitly
- Add unit tests for getTimeout method covering various timeout scenarios
- Add sample commands demonstrating persistent and vanishing notifications

Contributed on behalf of STMicroelectronics
@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Jan 20, 2026
@ndoschek ndoschek requested a review from eneufeld January 20, 2026 16:20
@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Needs merge in PR Backlog Jan 22, 2026
@ndoschek ndoschek merged commit 2485f3b into master Jan 23, 2026
10 checks passed
@ndoschek ndoschek deleted the nd/fix-notification-timeout branch January 23, 2026 08:42
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Jan 23, 2026
@github-actions github-actions bot added this to the 1.68.0 milestone Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants