fix(plugin): HostedPluginReader loads browser plugins relying on implicit .js resolution#16886
Merged
msujew merged 5 commits intoeclipse-theia:masterfrom Feb 2, 2026
Merged
Conversation
Signed-off-by: Fangxing Liu <fx.liu@tum.de>
Signed-off-by: Fangxing Liu <fx.liu@tum.de>
Signed-off-by: Fangxing Liu <fx.liu@tum.de>
Signed-off-by: Fangxing Liu <fx.liu@tum.de>
Fangoling
changed the title
Fangoling
changed the title
github-project-automation
bot
moved this from Waiting on reviewers
to Needs merge
in PR Backlog
msujew
reviewed
Jan 27, 2026
Signed-off-by: Fangxing Liu <fx.liu@tum.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #16884
The change adds a fallback mechanism to resolve plugin files with .js and .cjs extensions when the exact file path doesn't exist. This is implemented through a new resolveFile() method.
This change fixes the
vscodevim.vimextension and potentially other extensions that run into a similar issue.How to test
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers