Conversation
Comment on lines
+64
to
+69
| `The workspace trust feature is currently under development in Theia. | ||
|
|
||
| If you trust the authors, code in this folder may be executed. | ||
|
|
||
| If not, some features will be disabled. Please note that not all features are yet integrated with workspace trust (e.g., debug, tasks). | ||
| Check the 'Restricted Mode' indicator in the status bar for details.` |
Contributor
There was a problem hiding this comment.
Suggested change
| `The workspace trust feature is currently under development in Theia. | |
| If you trust the authors, code in this folder may be executed. | |
| If not, some features will be disabled. Please note that not all features are yet integrated with workspace trust (e.g., debug, tasks). | |
| Check the 'Restricted Mode' indicator in the status bar for details.` | |
| `If you trust the authors, code in this folder may be executed. | |
| If not, some features will be disabled. | |
| The workspace trust feature is currently under development in Theia; not all features are integrated with workspace trust yet. | |
| Check the 'Restricted Mode' indicator in the status bar for details.` |
Comment on lines
+197
to
+217
| protected getWorkspaceScopedServerNames(): Set<string> { | ||
| const workspaceScopedNames = new Set<string>(); | ||
|
|
||
| const inspection = this.preferenceService.inspect<JSONObject>(MCP_SERVERS_PREF); | ||
| if (!inspection) { | ||
| return workspaceScopedNames; | ||
| } | ||
|
|
||
| if (inspection.workspaceValue) { | ||
| for (const name of Object.keys(inspection.workspaceValue)) { | ||
| workspaceScopedNames.add(name); | ||
| } | ||
| } | ||
|
|
||
| if (inspection.workspaceFolderValue) { | ||
| for (const name of Object.keys(inspection.workspaceFolderValue)) { | ||
| workspaceScopedNames.add(name); | ||
| } | ||
| } | ||
|
|
||
| return workspaceScopedNames; |
Contributor
There was a problem hiding this comment.
I think it makes sense that these are the servers we'd really want to make sure don't autostart, but maybe it would make sense not to autostart any MCP servers, even though specified in user scope if workspace trust is denied? Basically, it's hard to know how the servers / LLM's using them might interact with malicious content in a workspace, so from a security perspective, it may be better to just block the autostart feature entirely? Particularly if the user can manually start any they're fully confident in.
Member
Author
There was a problem hiding this comment.
Thanks, that's a good point! I've updated it to block all MCP server autostart when workspace trust is denied. Users can still manually start servers they trust.
packages/ai-mcp/src/browser/mcp-frontend-application-contribution.ts
Outdated
Show resolved
Hide resolved
Resolves GH-16872 - Block workspace-scoped MCP servers with autostart in untrusted workspaces - Start blocked servers when trust is granted - Add WorkspaceRestrictionContribution API for packages to report restricted features in status bar tooltip
Co-authored-by: Colin Grant <cgrant.ext@eclipsesource.com>
colin-grant-work
approved these changes
Jan 28, 2026
Contributor
colin-grant-work
left a comment
colin-grant-work
left a comment
There was a problem hiding this comment.
Changes look good 👍
github-project-automation
bot
moved this from Waiting on reviewers
to Needs merge
in PR Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Resolves GH-16872
This PR integrates workspace trust into the MCP autostart logic:
Additionally, this introduces a
WorkspaceRestrictionContributionAPI, allowing packages to contribute information about restricted features to the "Restricted Mode" status bar tooltip.Remark: This might be replaced later on by a separate Restricted Mode view widget to control different functions and give better overview later on, but for now the information should be sufficient in the status bar item tooltip.
How to test
.theia/settings.jsoncontaining an mcp server definition, e.g.:{ "ai-features.mcp.mcpServers": { "Context7": { "type": "http", "serverUrl": "https://mcp.context7.com/mcp", "autostart": true }, } }Manage Workspace TrustFollow-ups
Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers