dev: improve clarity of sample contributions#16937
Merged
sdirix merged 1 commit intoeclipse-theia:masterfrom Feb 5, 2026
Merged
dev: improve clarity of sample contributions#16937sdirix merged 1 commit intoeclipse-theia:masterfrom
sdirix merged 1 commit intoeclipse-theia:masterfrom
Conversation
Clearly mark contributions of api-samples in UI and logs. This is useful for Theia developers to easily separate between framework and api-samples behavior when testing. - Use named logger 'api-samples' for consistent log identification - Prefix console logs with [api-samples] in electron-main context - Use unified 'API Samples' category for all commands - Append 'Sample' suffix to chat agent IDs and names - Prefix MCP tool and resource names with 'sample-' - Update notification messages to include 'Sample Updater' prefix
4810919 to
498d591
Compare
lucas-koehler
approved these changes
Feb 5, 2026
Contributor
lucas-koehler
left a comment
There was a problem hiding this comment.
Thanks @sdirix ! The changes LGTM and I can now identify API example contributions much more easily :)
I c ould also notice the api-samples logger being used 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Clearly mark contributions of api-samples in UI and logs.
This is useful for Theia developers to easily separate between framework and api-samples behavior when testing.
How to test
Run the example application(s) and check UI and logs
Follow-ups
Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers