Skip to content

dev: improve clarity of sample contributions#16937

Merged
sdirix merged 1 commit intoeclipse-theia:masterfrom
sdirix:dirix/improve-samples
Feb 5, 2026
Merged

dev: improve clarity of sample contributions#16937
sdirix merged 1 commit intoeclipse-theia:masterfrom
sdirix:dirix/improve-samples

Conversation

@sdirix
Copy link
Member

@sdirix sdirix commented Feb 4, 2026

What it does

Clearly mark contributions of api-samples in UI and logs.
This is useful for Theia developers to easily separate between framework and api-samples behavior when testing.

  • Use named logger 'api-samples' for consistent log identification
  • Prefix console logs with [api-samples] in electron-main context
  • Add 'Sample:' prefix to command labels for clear identification
  • Append 'Sample' suffix to chat agent IDs and names
  • Prefix MCP tool and resource names with 'sample-'
  • Update notification messages to include 'Sample Updater' prefix

How to test

Run the example application(s) and check UI and logs

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Feb 4, 2026
Clearly mark contributions of api-samples in UI and logs.
This is useful for Theia developers to easily separate between
framework and api-samples behavior when testing.

- Use named logger 'api-samples' for consistent log identification
- Prefix console logs with [api-samples] in electron-main context
- Use unified 'API Samples' category for all commands
- Append 'Sample' suffix to chat agent IDs and names
- Prefix MCP tool and resource names with 'sample-'
- Update notification messages to include 'Sample Updater' prefix
@sdirix sdirix force-pushed the dirix/improve-samples branch from 4810919 to 498d591 Compare February 4, 2026 14:14
@lucas-koehler lucas-koehler self-requested a review February 5, 2026 14:28
Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sdirix ! The changes LGTM and I can now identify API example contributions much more easily :)
I c ould also notice the api-samples logger being used 👍

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Needs merge in PR Backlog Feb 5, 2026
@sdirix sdirix merged commit b268541 into eclipse-theia:master Feb 5, 2026
10 checks passed
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Feb 5, 2026
@github-actions github-actions bot added this to the 1.69.0 milestone Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants