Skip to content

[merge editor] Improve scroll sync implementation#16947

Merged
ndoschek merged 1 commit intoeclipse-theia:masterfrom
pisv:GH-16946
Feb 11, 2026
Merged

[merge editor] Improve scroll sync implementation#16947
ndoschek merged 1 commit intoeclipse-theia:masterfrom
pisv:GH-16946

Conversation

@pisv
Copy link
Contributor

@pisv pisv commented Feb 5, 2026

What it does

Fixes #16946.

How to test

Use the reproduction steps in #16946 to verify that the issue is fixed.

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

Copy link
Member

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your improvement for the merge editor @pisv!
Scrolling is now perfectly in sync 😄

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Needs merge in PR Backlog Feb 11, 2026
@ndoschek ndoschek merged commit 8b5d40b into eclipse-theia:master Feb 11, 2026
10 checks passed
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Feb 11, 2026
@github-actions github-actions bot added this to the 1.69.0 milestone Feb 11, 2026
@pisv
Copy link
Contributor Author

pisv commented Feb 11, 2026

Great to hear that 😄 Thanks a lot for your review @ndoschek!

@pisv pisv deleted the GH-16946 branch February 11, 2026 15:42
pisv added a commit to 1C-Company/theia that referenced this pull request Feb 12, 2026
pisv added a commit to 1C-Company/theia that referenced this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[merge editor] Some issues with scroll sync

2 participants