Skip to content

feat: display images in chat request tree nodes#17024

Merged
eneufeld merged 2 commits intomasterfrom
fix/improve-image-support
Feb 26, 2026
Merged

feat: display images in chat request tree nodes#17024
eneufeld merged 2 commits intomasterfrom
fix/improve-image-support

Conversation

@eneufeld
Copy link
Contributor

What it does

Render image thumbnails in chat request nodes for both attachment-flow images (from context variables) and paste-flow images (inline #imageContext variable parts).

  • Render context-variable images as thumbnails below the request text
  • Render pasted inline images as thumbnails replacing #imageContext text labels, positioned where they were pasted in the text flow
  • Deduplicate images across both sources
  • Fix doResolve() to preserve resolver-enriched arg instead of overwriting it with the caller's original arg, so resolved image data survives variable resolution
  • Fix getMessages() to extract images from inline resolved variable parts in addition to context variables, so pasted images reach the LLM
  • Fix clearPendingImageAttachments() ordering to run after sendRequest(), ensuring the pending image registry is available during variable resolution

How to test

On Master:
Paste an image into the chat and see that the llm does not get the image.

image But the llm answers: image

With the fix, the llm gets the pasted image and we now render it also in the tree view.

All pasted images are shown in line where they were pasted.

All images added via context are shown grouped at the end of the message.

Follow-ups

We need to discuss how we want to handle images especially images in the context. To my understanding files in the context aren't directly send to the llm but just offered in a list that they are there. Images behave now different.

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

Render image thumbnails in chat request nodes for both attachment-flow images (from context variables) and paste-flow images (inline #imageContext variable parts).

- Render context-variable images as thumbnails below the request text
- Render pasted inline images as thumbnails replacing #imageContext text labels, positioned where they were pasted in the text flow
- Deduplicate images across both sources
- Fix doResolve() to preserve resolver-enriched arg instead of overwriting it with the caller's original arg, so resolved image data survives variable resolution
- Fix getMessages() to extract images from inline resolved variable parts in addition to context variables, so pasted images reach the LLM
- Fix clearPendingImageAttachments() ordering to run after sendRequest(), ensuring the pending image registry is available during variable resolution
@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Feb 19, 2026
@eneufeld eneufeld requested review from ndoschek and sdirix February 19, 2026 20:09
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! I only have minor comments

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Needs merge in PR Backlog Feb 23, 2026
@ndoschek ndoschek mentioned this pull request Feb 25, 2026
20 tasks
@eneufeld eneufeld force-pushed the fix/improve-image-support branch from 2562e6d to dbc44be Compare February 25, 2026 10:04
@eneufeld eneufeld requested a review from sdirix February 25, 2026 14:27
@eneufeld eneufeld merged commit 20e5839 into master Feb 26, 2026
10 checks passed
@eneufeld eneufeld deleted the fix/improve-image-support branch February 26, 2026 13:23
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Feb 26, 2026
@github-actions github-actions bot added this to the 1.69.0 milestone Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants